Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Use DynComparator for lexsort and partition #637

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

yjshen
Copy link
Contributor

@yjshen yjshen commented Nov 26, 2021

This PR is a follow-up of #414 to make LexicographicalPartitionIterator Send + Sync, and feasible to use across .await.

@codecov
Copy link

codecov bot commented Nov 26, 2021

Codecov Report

Merging #637 (ee97af4) into main (e8279a4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
+ Coverage   69.92%   69.93%   +0.01%     
==========================================
  Files         299      299              
  Lines       16627    16625       -2     
==========================================
+ Hits        11626    11627       +1     
+ Misses       5001     4998       -3     
Impacted Files Coverage Δ
src/compute/sort/mod.rs 26.19% <ø> (ø)
src/compute/partition.rs 100.00% <100.00%> (+8.57%) ⬆️
src/compute/sort/lex_sort.rs 66.66% <100.00%> (+0.45%) ⬆️
src/io/parquet/read/nested_utils.rs 77.45% <0.00%> (-0.99%) ⬇️
src/bitmap/utils/slice_iterator.rs 92.53% <0.00%> (+1.49%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8279a4...ee97af4. Read the comment docs.

@jorgecarleitao jorgecarleitao merged commit 97042cf into jorgecarleitao:main Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants